Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report linux desktop-related env vars in issue reporter #94472

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Report linux desktop-related env vars in issue reporter #94472

merged 1 commit into from
Apr 6, 2020

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Apr 5, 2020

Fixes #94388

@Tyriar Tyriar added this to the April 2020 milestone Apr 5, 2020
@Tyriar Tyriar self-assigned this Apr 5, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Apr 5, 2020

Haven't yet tested in Linux, queued a product build

@Tyriar Tyriar requested a review from RMacfarlane April 5, 2020 16:15
dsseng
dsseng reviewed Apr 5, 2020
View reviewed changes
Copy link
Contributor

@dsseng dsseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works almost right on Ubuntu 19.10
image
My XDG_CURRENT_DESKTOP is ubuntu:GNOME from the terminal (echo $XDG_CURRENT_DESKTOP), shown as Unity in VS Code

@Tyriar
Copy link
Member Author

Tyriar commented Apr 5, 2020

@sh7dm hmm weird, does your terminal profile/rc script set this somewhere?

@dsseng
Copy link
Contributor

dsseng commented Apr 5, 2020

I've seen this before in other apps, so no worries, probably some X.org configs or GDM3 set this value. It's not VS Code's fault for sure 😄

RMacfarlane
RMacfarlane approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@RMacfarlane RMacfarlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me!

@Tyriar Tyriar merged commit df8b833 into master Apr 6, 2020
@Tyriar Tyriar deleted the tyriar/94388 branch April 6, 2020 15:51
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dsseng dsseng dsseng left review comments

@RMacfarlane RMacfarlane RMacfarlane approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
April 2020
Development

Successfully merging this pull request may close these issues.

Add some environment variables on issues reported from Linux to help identify distro and desktop environment
3 participants
@Tyriar @dsseng @RMacfarlane